> - CMA can have a static variable (good to avoid clashes with a global
>   'sa_client' variable name too)

Sounds good - that's a goof on my part.

> - IPoIB does not use multicast module upstream, fix ipoib_multicast.c too.

Okay - As an FYI, I will probably submit the multicast module upstream for
2.6.20, along with some sort of support for userspace access.

> - Simplify sa_query.c changes a little.  I don't like the
>   "deref_client" name for a function, since it sounds too much like
>   dereferencing a pointer rather than dropping a reference.  And I
>   also didn't like ib_sa_client_get() having a magic side effect of
>   setting query->client.  So I just open-coded more stuff.

Those changes sound fine to me.

- Sean

_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to