On 08:38 Wed 20 Sep     , Hal Rosenstock wrote:
> Hi Yevgeny,
> 
> On Wed, 2006-09-20 at 02:36, Yevgeny Kliteynik wrote:
> > Hi Hal
> > 
> > I'm doing a major review of the osmtest.
> 
> Good. This has been long overdue.
> 
> > This patch is fixing a few bugs in osmtest where failures
> > were ignored. More precisely, osmtest was expecting error,
> > but got IB_SUCCESS and ignored the fact that it should have
> > gotten an error.
> > There are also a few changes to improve the code and osmtest
> > log readability.
> 
> Looks good at the code inspection level.
> 
> > More patches expected.
> 
> Thanks for the heads up.
> 
> > This patch is for trunk only.
> > 
> > I tested applying this patch before sending it. If you get the
> > patch rejected again - let me know.
> 
> It took the header file part but rejected all code blocks for osmtest.c
> :-(

It looks like modified and context lines have different numbers of
prefixed spaces.

Sasha

_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to