Krishna Kumar wrote: > Re-write all cma error cases to simplify code. Splitting > it as multiple patches (one per routine) in case some are > found not required (in which case, later ones may apply > with a fuzz).
Most of these seem to be a style issue. Should error handling be placed at the end of the function, or within an if (error) type check? Keeping it at the end of the function tends to make maintenance a little easier, otherwise, we end up either duplicating the error handling, or moving it back to the end of the function. I think the following patches make sense to apply: 3, 4, and 7. I'm not sure about 12. - Sean _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
