Sean Hefty <[EMAIL PROTECTED]> wrote on 10/17/2006 10:33:41 PM:
> Can you rework this patch without adding in extra flags to indicate what
has or
> has not been executed?
OK, will fix it accordingly.
thanks,
- KK
> Krishna Kumar wrote:
> > diff -ruNp org/drivers/infiniband/core/cma.c
new/drivers/infiniband/core/cma.c
> > --- org/drivers/infiniband/core/cma.c 2006-10-10 15:45:27.000000000
+0530
> > +++ new/drivers/infiniband/core/cma.c 2006-10-10 15:59:53.000000000
+0530
> > @@ -1515,6 +1515,8 @@ static void addr_handler(int status, str
> > {
> > struct rdma_id_private *id_priv = context;
> > enum rdma_cm_event_type event;
> > + int did_comp_exch = 0;
> > + int destroy = 0;
>
> As a general comment, I really don't think that we need to be overly
concerned
> about optimizing error handling at the expense of code readability.
>
>
> Thanks,
> - Sean
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
