> The other changes look fine. But note that if req->status == -ECANCELED and > time_after() is true, then it seems like a toss up as to which one can be > reported to the user.
I felt that since the time_after() check matched (in all likelyhood) due to the processing of the cancellation, ECANCELLED is more appropriate to return. It is most likely that if both conditions are true, that a cancelled operation led to the time_after() match (cancel sets time to jiffies resulting in this time_after match). Chances of both happening together is almost zero. Do you agree ? Otherwise I can re-work the patch as suggested. thanks, - KK _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
