Roland Dreier wrote: > I'm not sure about this -- does this lead to duplication of code like > keeping track of outstanding requests? Or are you exporting some > really low-level interface from ib_sa?
This did not lead to code duplication. As you guessed, I exported the send_mad() interface. > Maybe the best thing to do is put the higher level multicast handling > into the ib_sa module (and not export the current lower level > multicast APIs any more). EXPORT_SYMBOL isn't totally free and if > we're exporting really internal stuff for one other user (I'm guessing > that you might be building on top of the sa_query.c::send_mad() level > stuff), then we might as well just combine the multicast and SA > modules into a single .ko (even if there are multiple .c files). This makes sense. > Maybe ib_notice should just go into ib_sa as well. I think this would actually end up being easier / more efficient. Ib_notice needs to register for unsolicited MADs, so I was going to have it register with the ib_mad module directly to receive those. But I didn't want to duplicate tracking the SA's address handle. -Sean _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
