Get rid of extra call to list_empty(), and unnecessary
variable. Has the side effect of sometimes resulting in
faster processing of new events (like handling new
connections, eg when cm_work_handler was processing the
last entry) added to this list instead of cm_work_handler
function exiting and re-entering when a new queue_work()
is done.
Doing the redundant queue_work() (if cm_work_handler is
already running and processing the last entry) will not
result in another call to cm_work_handler (run_workqueue)
where no entry is found, since cm_work_handler will remove
all entries from the list, even ones that are added late.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
diff -ruNp org/drivers/infiniband/core/iwcm.c new/drivers/infiniband/core/iwcm.c
--- org/drivers/infiniband/core/iwcm.c 2006-10-09 16:40:04.000000000 +0530
+++ new/drivers/infiniband/core/iwcm.c 2006-10-09 16:52:03.000000000 +0530
@@ -834,22 +834,17 @@ static void cm_work_handler(void *arg)
struct iw_cm_event levent;
struct iwcm_id_private *cm_id_priv = work->cm_id;
unsigned long flags;
- int empty;
- int ret = 0;
spin_lock_irqsave(&cm_id_priv->lock, flags);
- empty = list_empty(&cm_id_priv->work_list);
- while (!empty) {
+ while (!list_empty(&cm_id_priv->work_list)) {
work = list_entry(cm_id_priv->work_list.next,
struct iwcm_work, list);
list_del_init(&work->list);
- empty = list_empty(&cm_id_priv->work_list);
levent = work->event;
put_work(work);
spin_unlock_irqrestore(&cm_id_priv->lock, flags);
- ret = process_event(cm_id_priv, &levent);
- if (ret) {
+ if (process_event(cm_id_priv, &levent)) {
set_bit(IWCM_F_CALLBACK_DESTROY, &cm_id_priv->flags);
destroy_cm_id(&cm_id_priv->id);
}
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
