> While yes, we should not in general add new workarounds before we need > them, for this quirk, you should keep the original functionality, > unless > you wrote the quirk, or unless you have the hardware that needs it and > you can verify that the change works properly. > > Are any of these last two options true for you?
This new code only runs on HyperTransport devices and none of those _existed_ when the quirk was first written. I cannot claim I know for sure it is never needed there of course, but it's quite improbable at least. > If not, I suggest that you put the TTL logic back in just to be safe. I'm fine with that -- but I'm not writing the code here, Michael is, and I just hope he has more spine than I do ;-) Segher _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
