On Mon, 2007-02-12 at 11:58 -0800, Roland Dreier wrote: > Looks mostly sane (assuming it works on 32-bit userspace on 64-bit > kernel now), but: > > > - context = kmalloc(sizeof(*context), GFP_KERNEL); > > + context = kzalloc(sizeof(*context), GFP_KERNEL); > > Why do you need this? Is this an unrelated change? >
Because the key generator u32 is in the context now, and the kzalloc() initializes it. I could have done: context->key = 0; But km -> kz was less typing. ;-) Steve. _______________________________________________ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general