On Friday 06 January 2006 15:39, Matt Domsch wrote:
> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> ...
> +config DMI
> + bool
> + default y
Should we have a way to turn this off?
> diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
> ...
> +dmi_scan-y += ../../i386/kernel/dmi_scan.o
Ugh. I really hate this sort of sharing. Could dmi_scan.c go in
drivers/firmware/ or something instead?
> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
> ...
> +static int __init run_dmi_scan(void)
> +{
> + dmi_scan_machine();
> + return 0;
> +}
> +core_initcall(run_dmi_scan);
Shouldn't this be wrapped in "#ifdef CONFIG_DMI"?
Sorry this feedback is so late. I only looked at it because the
DMI stuff crashes HP sx2000 (and probably sx1000) boxes, probably
because of some memory attribute problem. So I'll have more
feedback after I debug that ;-)
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
