Yes, the start of the kernel thread needs to be moved to after the call
to ipmi_register_smi().  Otherwise, a message could come in before the
upper layer was ready to receive it.

You want to do a patch?

-Corey

Matt Domsch wrote:

>FYI, this was just reported to me this morning, I haven't had a chance
>to look into it yet.  This was an oops in the IPMI kernel thread on a
>PowerEdge 2650 (SMIC interface) on RHEL4 "gold" with the 33.12.RHEL4
>driver set.
>
>
>
>Mar 23 15:15:33 localhost kernel: ipmi message handler version 33.12
>Mar 23 15:15:33 localhost kernel: IPMI System Interface driver version
>   33.12, KCS version 33.12, SMIC version 33.12, BT vers\ion 33.12
>Mar 23 15:15:33 localhost kernel: Unable to handle kernel NULL pointer 
>dereference at virtual address 00000008
>Mar 23 15:15:33 localhost kernel:  printing eip:
>Mar 23 15:15:33 localhost kernel: c02c4e74
>Mar 23 15:15:33 localhost kernel: *pde = 36271001
>Mar 23 15:15:33 localhost kernel: Oops: 0000 [#1]
>Mar 23 15:15:33 localhost kernel: SMP
>Mar 23 15:15:33 localhost kernel: Modules linked in: ipmi_si(U)
>  ipmi_msghandler(U) dell_rbu(U) parport_pc lp parport autofs4\ i2c_dev
>  i2c_core md5 ipv6 ppp_async ppp_generic slhc crc_ccitt sunrpc button
>  battery ac ohci_hcd tg3(U) floppy sg dm_snapsh\ot dm_zero dm_mirror
>  ext3 jbd dm_mod megaraid_mbox(U) megaraid_mm(U) aacraid(U) sd_mod
>  scsi_mod
>Mar 23 15:15:33 localhost kernel: CPU:    0
>Mar 23 15:15:33 localhost kernel: EIP:    0060:[<c02c4e74>]    Not tainted VLI
>Mar 23 15:15:33 localhost kernel: EFLAGS: 00010046   (2.6.9-5.ELsmp)
>Mar 23 15:15:33 localhost kernel: EIP is at _read_lock+0x0/0x1d
>Mar 23 15:15:33 localhost kernel: eax: 00000004   ebx: f7fe9e00   ecx: 
>00000000   edx: f76aa800
>Mar 23 15:15:33 localhost kernel: esi: f76aa800   edi: 00000000   ebp: 
>f7fe9e00   esp: f62fdf58
>Mar 23 15:15:33 localhost kernel: ds: 007b   es: 007b   ss: 0068
>Mar 23 15:15:33 localhost kernel: Process kipmi0 (pid: 4063, 
>threadinfo=f62fd000 task=f63418b0)
>Mar 23 15:15:33 localhost kernel: Stack: f8b77bee f7fe9e00 f7fe9e14 f76aa800 
>f7fe9e00 f8b6a027 f7fe9ec8 f76aa800
>Mar 23 15:15:33 localhost kernel:        f7fe9e00 f8b6a441 00000930 f7fe9e3c 
>f8b6cec7 f7fe9e40 00000000 f7fe9e00
>Mar 23 15:15:33 localhost kernel:        000002e4 f7fe9ec8 f7fe9e00 00000000 
>f8b6a523 fe55014c 00000246 f7fe9e14
>Mar 23 15:15:33 localhost kernel: Call Trace:
>Mar 23 15:15:33 localhost kernel:  [<f8b77bee>] 
>ipmi_smi_msg_received+0x10/0x110 [ipmi_msghandler]
>Mar 23 15:15:33 localhost kernel:  [<f8b6a027>] deliver_recv_msg+0x1b/0x25 
>[ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<f8b6a441>] 
>handle_transaction_done+0x188/0x21a [ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<f8b6cec7>] smic_event+0x4d6/0x5c4 
>[ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<f8b6a523>] smi_event_handler+0x50/0x14b 
>[ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<f8b6a747>] ipmi_thread+0x30/0x77 [ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<f8b6a717>] ipmi_thread+0x0/0x77 [ipmi_si]
>Mar 23 15:15:33 localhost kernel:  [<c0131dcd>] kthread+0x73/0x9b
>Mar 23 15:15:33 localhost kernel:  [<c0131d5a>] kthread+0x0/0x9b
>Mar 23 15:15:33 localhost kernel:  [<c01041f1>] kernel_thread_helper+0x5/0xb
>Mar 23 15:15:33 localhost kernel: Code: f3 90 80 3b 00 7e f9 eb f2 5b
>  c3 81 78 04 ed 1e af de 74 08 0f 0b cf 00 6c 74 2d c0 \f0 81 28 00 00
>  00 01 74 05 e8 69 ee ff ff c3 <81> 78 04 ed 1e af de 74 08 0f 0b c7 00
>  6c 74 2d c0 f0 83 28 01
>Mar 23 15:15:33 localhost kernel:  <6> IPMI smic interface initialized
>Mar 23 15:15:33 localhost kernel: ipmi device interface version 33.12
>
>
>
>Thanks,
>Matt
>
>  
>



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to