[EMAIL PROTECTED] wrote: > From: David Barksdale <[EMAIL PROTECTED]> > > This patch adds the ability to register for a command per-channel. > > If your BMC supports multiple channels, incoming messages can be > differentiated by the channel on which they arrived. In this case it's > useful to have the ability to register to receive commands on a > specific channel instead the current behaviour of all channels. > > Sorry for the long delay on this. I like the patch in general, there are a few things I'd like to fix in it, though:
* Instead of naming the IOCTLs xxx_CMD2, could you name them xxx_CMD_CHANNEL, or something that conveys a little more meaning? * The command unregister function needs to use a different matching function now that you have to allow non-exact matches for the channels. You still need an exact match for unregistering. * Someone mentioned using a bitmask for the channels you are registering. I think that's a good idea. IPMI only allows 16 channels max, so an unsigned int should be plenty. Add a define for all channels and for setting a specific channel. Thanks, -Corey Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
