Wow, that system had been up a long time. I can't use the patch as-is, as this code has been rewritten recently to use atomics, but this needs to be fixed in several places. I'll work on a patch for this.
Thanks, -corey Nathan Scott wrote: > Hi there, > > I came across some negative values in /proc/ipmi/0 on one of our > production systems; these values are unsigned long in the driver > so should probably be sprintf'd into the procfs buffer that way? > > cheers. > > > ------------------------------------------------------------------------ > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c > b/drivers/char/ipmi/ipmi_si_intf.c > index 4f560d0..5576006 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2405,29 +2405,29 @@ static int stat_file_read_proc(char *page, char > **start, off_t off, > > out += sprintf(out, "interrupts_enabled: %d\n", > smi->irq && !smi->interrupt_disabled); > - out += sprintf(out, "short_timeouts: %ld\n", > + out += sprintf(out, "short_timeouts: %lu\n", > smi->short_timeouts); > - out += sprintf(out, "long_timeouts: %ld\n", > + out += sprintf(out, "long_timeouts: %lu\n", > smi->long_timeouts); > - out += sprintf(out, "timeout_restarts: %ld\n", > + out += sprintf(out, "timeout_restarts: %lu\n", > smi->timeout_restarts); > - out += sprintf(out, "idles: %ld\n", > + out += sprintf(out, "idles: %lu\n", > smi->idles); > - out += sprintf(out, "interrupts: %ld\n", > + out += sprintf(out, "interrupts: %lu\n", > smi->interrupts); > - out += sprintf(out, "attentions: %ld\n", > + out += sprintf(out, "attentions: %lu\n", > smi->attentions); > - out += sprintf(out, "flag_fetches: %ld\n", > + out += sprintf(out, "flag_fetches: %lu\n", > smi->flag_fetches); > - out += sprintf(out, "hosed_count: %ld\n", > + out += sprintf(out, "hosed_count: %lu\n", > smi->hosed_count); > - out += sprintf(out, "complete_transactions: %ld\n", > + out += sprintf(out, "complete_transactions: %lu\n", > smi->complete_transactions); > - out += sprintf(out, "events: %ld\n", > + out += sprintf(out, "events: %lu\n", > smi->events); > - out += sprintf(out, "watchdog_pretimeouts: %ld\n", > + out += sprintf(out, "watchdog_pretimeouts: %lu\n", > smi->watchdog_pretimeouts); > - out += sprintf(out, "incoming_messages: %ld\n", > + out += sprintf(out, "incoming_messages: %lu\n", > smi->incoming_messages); > > return out - page; > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
