Corey, Thanks. I had only tested it on 2.6.14 and earlier kernels, so it does need to be ported to something more current. I'll work on that.
Having the back-compatiblity already in there is convenient for me, but I can see that it would seem like clutter if this is patch gets included in the base kernel. Andy -----Original Message----- From: Corey Minyard [mailto:[EMAIL PROTECTED] Sent: Monday, April 21, 2008 3:54 PM To: Cress, Andrew R Cc: [email protected] Subject: Re: [Openipmi-developer] ipmi_imb (emu) updates for compat Cress, Andrew R wrote: > Corey, > > I ran into a case that required ipmi_imb and CONFIG_COMPAT, and ipmi_imb > did not previously support it, so I have attached the updated source > with those changes. > I included the source files since they are created by the patch anyway. > Any comments? > Could a form of this get merged in for the next driver version? > > Andy > Well, patches are still really appreciated as they are easier to review. This patch has a lot of problems; it will really only work on older kernels and will definitely not work on current kernels. The compat stuff has changed a lot (and devfs is not longer there and you can no longer include config.h, among other things). Does the change really need to have all the backwards compatibility changes? I'm attaching the patch, BTW. -corey ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
