Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman <[email protected]> > > In the near future, the driver core is going to not allow direct access > to the driver_data pointer in struct device. Instead, the functions > dev_get_drvdata() and dev_set_drvdata() should be used. These functions > have been around since the beginning, so are backwards compatible with > all older kernel versions. > > Cc: [email protected] > Cc: Corey Minyard <[email protected]> > Looks good to me.
Acked-by: Corey Minyard <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > drivers/char/ipmi/ipmi_si_intf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2375,14 +2375,14 @@ static int __devinit ipmi_of_probe(struc > info->io.addr_data, info->io.regsize, info->io.regspacing, > info->irq); > > - dev->dev.driver_data = (void *) info; > + dev_set_drvdata(&dev->dev, info); > > return try_smi_init(info); > } > > static int __devexit ipmi_of_remove(struct of_device *dev) > { > - cleanup_one_si(dev->dev.driver_data); > + cleanup_one_si(dev_get_drvdata(&dev->dev)); > return 0; > } > > > ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
