Here's a sample of how I think the ACPI namespace device detection should
be done.  I think this is almost functionally equivalent to your "Locate
the IPMI system interface in ACPI namespace" patch.

The difference I'm aware of is that your patch doesn't call acpi_register_gsi()
for IRQs from the device _CRS, so I don't think those interrupts would work.
(I can't test this because I don't have a box that reports an IRQ in _CRS.)
PNPACPI takes care of this GSI registration for us.

Patches 3 & 4 are not really related to the main point here, but I left
them in because without 4, we'll report both SPMI and ACPI namespace
devices as being from "ACPI".

---

Bjorn Helgaas (5):
      PNPACPI: save struct acpi_device, not just acpi_handle
      PNP: add interface to retrieve ACPI device from a PNPACPI device
      ipmi: remove unused PCI probe code
      ipmi: refer to table as "SPMI", not "ACPI"
      ipmi: add PNP discovery (ACPI namespace via PNPACPI)


 drivers/char/ipmi/ipmi_si_intf.c |  118 +++++++++++++++++++++++++++++++++++---
 drivers/pnp/pnpacpi/core.c       |   19 ++++--
 drivers/pnp/pnpacpi/rsparser.c   |    9 ++-
 include/linux/pnp.h              |   13 ++++
 4 files changed, 141 insertions(+), 18 deletions(-)

-- 
Bjorn

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to