On 07/26/2010 11:41 PM, Yinghai Lu wrote: > On 07/26/2010 07:05 PM, Corey Minyard wrote: > >> Please run this through checkpatch, as it has coding style violations. >> > y...@linux-siqj:~/xx/xx/kernel/tip/linux-2.6> ./scripts/checkpatch.pl > patches/ipmi_reg_size.patch > total: 0 errors, 0 warnings, 105 lines checked > > patches/ipmi_reg_size.patch has no obvious style problems and is ready for > submission. > y...@linux-siqj:~/xx/xx/kernel/tip/linux-2.6> > Sorry, you are right.
> >> Also, this patch appears to fix bugs in addition to adding the print. >> Can we have a separate patch for that? >> > in the comment log, i already mentioned that. > > will separate it to twol > Ok, thanks > >> I'm also not clear on the reason for this. I believe all this >> information is already available in /proc/ipmi/<if#>/params. I don't >> think there is a strong reason to print it to the log. >> > then why there is printing for ACPI path and pci path? > Well, I'm not sure on this. You are right, it is printed for those paths and not for DMI or SPMI cases. Printing too much information is not generally a good idea, but this may be useful. I guess to make it consistent it would be best to add this. -corey ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://ad.doubleclick.net/clk;226879339;13503038;l? http://clk.atdmt.com/CRS/go/247765532/direct/01/ _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
