Applied, thank you. -corey
On 09/24/2013 11:21 PM, Nikita Yushchenko wrote: >>> With RMCP+, there is EINVAL, originatiing from >>> >>> if (memcmp(data+40, integ_data, rinfo->key_len) != 0) >>> return EINVAL; >>> >>> in rakp_hmac_c2(). >>> >>> I suggest to replace this EINVAL with something other, to let >>> application detect and handle invalid login credentials. Maybe EACCES, >>> or some specific error code. >>> >>> >>> Other very questionable EINVAL is where ''Requested authentication not >>> supported' message is logged in auth_cap_done(). Some better value >>> could be returned here, maybe ENOTSUP. >>> >>> What do you think? >> I'm fine with changing both of these. >> >> -corey > Hi > > Attached is a patch that I currently have in my tree to detect bad password > errors. > > For the rest, I currently only have dirty fixes (i.e. that fixes this > hardware by breaking other). I will submit clean patches if/when those are > ready. > > Nikita > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
