On Wednesday 07 January 2015 12:51:50 John Stultz wrote:
> As part of the internal y2038 cleanup, this patch removes
> timespec usage in the ipmi driver, replacing it timespec64
>
> Cc: Corey Minyard <[email protected]>
> Cc: [email protected]
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: John Stultz <[email protected]>
>
In other drivers, we tended to use ktime_t and monotonic time,
but your approach is definitely simpler because it doesn't have
to rework the ipmi_si_is_busy logic and just do a
s/timespec/timespec64/ conversion.
Do you think it makes sense to use ktime_get_ts64 instead of
getnstimeofday64 to get a monotonic time? The advantage would
be to have the code work slightly better when racing against
settimeofday, the downside would be that the debug printk
shows the changed time base, but that would hopefully be
irrelevant to someone debugging the code.
Arnd
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
