Hi,

We received a few bug reports about the openipmi init-script unloading
all IPMI kernel modules on error
(https://bugs.launchpad.net/ubuntu/+source/openipmi/+bug/1318317).

This seems to be a side-effect of the default openipmi possibly being
incorrect, but it seems like an unnecessary side-effect that an error
leads to all IPMI kernel modules are unloaded.

Signed-off-by: Nishanth Aravamudan <[email protected]>

diff --git a/ipmi.init b/ipmi.init
index 2ebcd94..cb3c7e3 100644
--- a/ipmi.init
+++ b/ipmi.init
@@ -373,9 +373,9 @@ load_ipmi_modules ()
        local locdelay
        modprobe ipmi_msghandler > /dev/null 2>&1
        modules_loaded ipmi_msghandler
-       [ ${OnePlusLoaded} -ne 1 ] && unload_all_ipmi_modules && 
RETVAL=$((RETVAL | 1)) && return
+       [ ${OnePlusLoaded} -ne 1 ] && RETVAL=$((RETVAL | 1)) && return
        load_hw_modules
-       [ $((RETVAL & 1)) -eq 1 ] && unload_all_ipmi_modules && 
RETVAL=$((RETVAL | 1)) && return
+       [ $((RETVAL & 1)) -eq 1 ] && return
 
        if [ "${DEV_IPMI}" = "yes" ]; then
                modprobe ipmi_devintf > /dev/null 2>&1

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140
_______________________________________________
Openipmi-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to