On 06/20/2016 04:57 PM, Corey Minyard wrote: > On 06/20/2016 01:26 PM, Tony Camuso wrote: >> Port I/O space does not exist in ARM64 and is not mapped. Attempts to >> access it on ARM systems cause stack traces and worse. > > At this point, I think it is best to just completely pull out all concept > of "default addresses" in the IPMI driver. The defaults were disabled > by default in 3.16, this is as good an impetus as any to just get rid > of them. > > If you want, you can do a patch, or I can pull them out if you would > prefer that.
I'll give it a go. Should have something later today. Regards, Tony > > Thanks, > > -corey > >> Signed-off-by: Tony Camuso <[email protected]> >> --- >> drivers/char/ipmi/ipmi_si_intf.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/char/ipmi/ipmi_si_intf.c >> b/drivers/char/ipmi/ipmi_si_intf.c >> index 615abbf..85dcc86 100644 >> --- a/drivers/char/ipmi/ipmi_si_intf.c >> +++ b/drivers/char/ipmi/ipmi_si_intf.c >> @@ -3841,6 +3841,11 @@ static int init_ipmi_si(void) >> spmi_find_bmc(); >> #endif >> +#ifdef CONFIG_ARM64 >> + /* Don't touch port io space */ >> + si_trydefaults = 0; >> +#endif >> + >> #ifdef CONFIG_PARISC >> register_parisc_driver(&ipmi_parisc_driver); >> parisc_registered = true; > ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
