Ok, these are in my tree going to linux-next. I made the following changes:
The calls to ipmi_demangle_device_id() in ipmi_ssif.c and ipmi_si_intf.c
were
passing in the command and netfn from the message, not the response.
I changed it to the response.
I also fixed some coding style issues, spaced are required around "+", so
I added those. The checkpatch script wasn't giving an error on that,
but it's clearly stated in the coding style manual.
I renamed dyn_id to dyn_id_state to better reflect it's function, and I used
the enum type to define it instead of "int".
I added a comment above null_user_handler to state that it was
used by querying the BMC device ID, and if it was used by anything
else a mutex would be required.
If that's ok, this is ready to go.
-corey
On 08/25/2017 02:47 AM, Jeremy Kerr wrote:
This series implements a more dynamic method of reporting BMC version &
identification. The current method of registering versions and IDs
during ipmi_register_smi means that if a BMC is upgraded during a boot,
the IPMI core code will report old version information.
We do this by querying the BMC (using a Get Device ID request) at smi
registration in the IPMI core code, and when the sysfs version & id
attributes are accessed.
The core of the change is in patch 3/4. Patches 1 and 2 implement a
couple of minor API changes leading up to this.
Patch 4 converts the powernv IPMI driver to use the dynamic IDs, rather
than using a zero device ID.
Questions & comments most welcome.
Cheers,
Jeremy
---
resend: this is a resend of v2, rebased to current master.
v2:
- enable dynamic device IDs for existing interfaces and remove the
_DISABLED state
- use a mutex to protect against concurrent id update
- comment spelling fix
- don't repeat checks from ipmi_demangle_device_id
- fix for shifted netfn values in ipmi_demangle_device_id, update comments
to reflect new interface
Jeremy Kerr (4):
ipmi: Add a reference from BMC devices to their interfaces
ipmi: Make ipmi_demangle_device_id more generic
ipmi: allow dynamic BMC version information
ipmi/powernv: Use dynamic device ids
drivers/char/ipmi/ipmi_msghandler.c | 268 ++++++++++++++++++++++++++++++++----
drivers/char/ipmi/ipmi_powernv.c | 5 +-
drivers/char/ipmi/ipmi_si_intf.c | 3 +-
drivers/char/ipmi/ipmi_ssif.c | 3 +-
include/linux/ipmi_smi.h | 24 ++--
5 files changed, 260 insertions(+), 43 deletions(-)
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
