On 09/07/2017 03:43 PM, Jeremy Kerr wrote:
Hi Corey,
Thanks for the rework, on an initial look it seems pretty good. I'll
give it some testing on our machines here.
One question on this, do you need this for 3.14? I'd rather wait for 3.15
for something this invasive, but it can probably be worked in if critical.
We do need *something* for 4.14, to address the might-sleep-while-atomic
issue. And I'd agree that this does seem a little large a change for
this stage in the merge cycle.
A couple of options would be:
- revert the initial dynamic device patches, and go back to no device
ID on powernv.
I had actually already removed the patches, the patches that I posted
replace them.
After thinking about it more, I realized that dynamically changing the
device id could
result in issues.
- use the spinlock patch as a temporary workaround, until 4.15 where
this series replaces it. What were the issues around that change?
They could be more easily done with a temporary variable and memory
barriers.
But that wasn't the main issue I ended up fixing.
There is a patch near the end of the series that changes the BMC naming
to not
use the product and device id in the name, which should cover a lot of the
issues that might show up with name collisions. However, that is a
functional
change that I'm a little worried about.
But I could use that patch and the dynamic device id patch, and the
worst thing
that could happen is the same BMC could show up as two different BMCs
on two different interfaces. I think. The changes wouldn't be that large.
-corey
Cheers,
Jeremy
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
