Corey, On 19.07.18 19:29:47, Corey Minyard wrote: > What we need to do is find out what the spec writers really meant. I looked > at the errata and I couldn't find anything.
I looked into the spec as well, and I think there might be an explanation on how multipart writes should be implemented. In your earlier mail (https://lkml.org/lkml/2018/7/6/922) and in your code comment for SSIF_MULTI_n_PART you basically wrote, that the end part of the message is 1-31 bytes in length and is determined by length not equal 32 bytes (as implied by Table 12-4 of the spec). However, I think the other statement of the spec is more true here: "The number of message data bytes in the End transaction can range from 1 to 32 bytes." IMO, in contrast to table 12-4 the end transaction is not using cmd 07h as for the middle command, but instead 08h as described in Table 12-10. So with that different cmd used for the end transaction it would be possible to send 32 bytes in the last block. Cmd enumeration indicates that 08h is actually assigned (all cmds are used from 0 to 0Ah). So by using command 08h for the last block, messages with a length of multiples of 32 bytes could be sent. What do you think? Kamlakant, could your rework your patch accordingly? Thanks, -Robert ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
