On Mon, Nov 12, 2018 at 10:15:41AM -0600, Corey Minyard wrote: > On 11/12/18 10:04 AM, Paul E. McKenney wrote: > >On Mon, Nov 12, 2018 at 09:38:55AM -0600, Corey Minyard wrote: > >>On 11/11/18 1:43 PM, Paul E. McKenney wrote: > >>>Now that synchronize_rcu() waits for preempt-disable regions of code > >>>as well as RCU read-side critical sections, synchronize_sched() can be > >>>replaced by synchronize_rcu(). This commit therefore makes this change. > >>Assuming the above is true, this looks fine to me. > >> > >>Acked-by: Corey MInyard <cminy...@mvista.com> > > Dang, that's > > Acked-by: Corey Minyard <cminy...@mvista.com>
Just in time, applied, thank you! ;-) > >Thank you! > > > >>Or I can take it in my tree, either way. > >I will carry it unless/until I send it upstream (this coming merge > >window) or I see it already upstream. > > > >So your choice. ;-) > > Ok, if you don't mind, you can carry it. Sounds good! Thanx, Paul > Thanks, > > -corey > > > > Thanx, Paul > > > >>-corey > >> > >> > >>>Signed-off-by: Paul E. McKenney <paul...@linux.ibm.com> > >>>Cc: Corey Minyard <miny...@acm.org> > >>>Cc: Arnd Bergmann <a...@arndb.de> > >>>Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > >>>Cc: <openipmi-developer@lists.sourceforge.net> > >>>--- > >>> drivers/char/ipmi/ipmi_si_intf.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>>diff --git a/drivers/char/ipmi/ipmi_si_intf.c > >>>b/drivers/char/ipmi/ipmi_si_intf.c > >>>index 677618e6f1f7..dc8603d34320 100644 > >>>--- a/drivers/char/ipmi/ipmi_si_intf.c > >>>+++ b/drivers/char/ipmi/ipmi_si_intf.c > >>>@@ -2187,7 +2187,7 @@ static void shutdown_smi(void *send_info) > >>> * handlers might have been running before we freed the > >>> * interrupt. > >>> */ > >>>- synchronize_sched(); > >>>+ synchronize_rcu(); > >>> /* > >>> * Timeouts are stopped, now make sure the interrupts are off > >> > _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer