On Wed, Apr 17, 2019 at 08:49:18AM -0400, Tony Camuso wrote:
> On 4/16/19 5:31 PM, miny...@acm.org wrote:
> > From: Corey Minyard <cminy...@mvista.com>
> >
> > An extra memset was put into a place that cleared the interface
> > type.
> >
> > Reported-by: Tony Camuso <tcam...@redhat.com>
> > Fixes: 3cd83bac481dc4 ("ipmi: Consolidate the adding of platform devices")
> > Signed-off-by: Corey Minyard <cminy...@mvista.com>
> > ---
> > drivers/char/ipmi/ipmi_dmi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > Well, that was a stupid mistake. Sorry about that. Thanks
> > for reporting.
> >
> > diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c
> > index ff0b199be472..f2411468f33f 100644
> > --- a/drivers/char/ipmi/ipmi_dmi.c
> > +++ b/drivers/char/ipmi/ipmi_dmi.c
> > @@ -66,7 +66,6 @@ static void __init dmi_add_platform_ipmi(unsigned long
> > base_addr,
> > return;
> > }
> > - memset(&p, 0, sizeof(p));
> > p.addr = base_addr;
> > p.space = space;
> > p.regspacing = offset;
> >
>
> That was fast!
When you look at it and say "Doh!", it's pretty easy :).
If this solves your problem, I'll push it up to Linus for 5.1.
-corey
>
> Thanks!
>
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
