On Wed, 05 Feb 2020 10:31:46 +0100,
Takashi Iwai wrote:
>
> Although the IRQ assignment in ipmi_si driver is optional,
> platform_get_irq() spews error messages unnecessarily:
> ipmi_si dmi-ipmi-si.0: IRQ index 0 not found
>
> Fix this by switching to platform_get_irq_optional().
>
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()")
> Reported-and-tested-by: Patrick Vo <patrick...@hpe.com>
> Signed-off-by: Takashi Iwai <ti...@suse.de>
Any review / ack on this?
thanks,
Takashi
> ---
> drivers/char/ipmi/ipmi_si_platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_platform.c
> b/drivers/char/ipmi/ipmi_si_platform.c
> index c78127ccbc0d..638c693e17ad 100644
> --- a/drivers/char/ipmi/ipmi_si_platform.c
> +++ b/drivers/char/ipmi/ipmi_si_platform.c
> @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct platform_device
> *pdev)
> else
> io.slave_addr = slave_addr;
>
> - io.irq = platform_get_irq(pdev, 0);
> + io.irq = platform_get_irq_optional(pdev, 0);
> if (io.irq > 0)
> io.irq_setup = ipmi_std_irq_setup;
> else
> @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device *pdev)
> io.irq = tmp;
> io.irq_setup = acpi_gpe_irq_setup;
> } else {
> - int irq = platform_get_irq(pdev, 0);
> + int irq = platform_get_irq_optional(pdev, 0);
>
> if (irq > 0) {
> io.irq = irq;
> --
> 2.16.4
>
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
