On Tue, Apr 14, 2020 at 10:19:51PM +0800, Tang Bin wrote:
> The priority of dev_warm() is higher than dev_info(),so if the
> function bt_bmc_probe() uses dev_info() to print error message,
> the dev_warm() is redundant.Thus should be removed.
Actually, this needs to be left in. That error is not just a that irqs
were not configured, that's an error that something else went wrong.
-corey
>
> Signed-off-by: Tang Bin <tang...@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshen...@cmss.chinamobile.com>
> ---
> drivers/char/ipmi/bt-bmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index cd0349bff..1d4bf5c65 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -406,7 +406,6 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc,
> rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED,
> DEVICE_NAME, bt_bmc);
> if (rc < 0) {
> - dev_warn(dev, "Unable to request IRQ %d\n", bt_bmc->irq);
> bt_bmc->irq = 0;
> return rc;
> }
> --
> 2.20.1.windows.1
>
>
>
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
