[Openipmi-developer] [PATCH] ipmi: print current state when error

[Xianting Tian]

Print current state before returning IPMI_NOT_IN_MY_STATE_ERR,
we can know where this issue is coming from and possibly fix
the state machine.

Signed-off-by: Xianting Tian <tian.xiant...@h3c.com>
---
 drivers/char/ipmi/ipmi_bt_sm.c   | 4 +++-
 drivers/char/ipmi/ipmi_kcs_sm.c  | 4 +++-
 drivers/char/ipmi/ipmi_smic_sm.c | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index f3f216cdf..2de0c6c30 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -213,8 +213,10 @@ static int bt_start_transaction(struct si_sm_data *bt,
        if (bt->state == BT_STATE_LONG_BUSY)
                return IPMI_NODE_BUSY_ERR;
 
-       if (bt->state != BT_STATE_IDLE)
+       if (bt->state != BT_STATE_IDLE) {
+               dev_warn(bt->io->dev, "BT is now in the state %d\n", bt->state);
                return IPMI_NOT_IN_MY_STATE_ERR;
+       }
 
        if (bt_debug & BT_DEBUG_MSG) {
                dev_dbg(bt->io->dev, "+++++++++++++++++ New command\n");
diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index 2e7cda08b..49ece4ba3 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -268,8 +268,10 @@ static int start_kcs_transaction(struct si_sm_data *kcs, 
unsigned char *data,
        if (size > MAX_KCS_WRITE_SIZE)
                return IPMI_REQ_LEN_EXCEEDED_ERR;
 
-       if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED))
+       if ((kcs->state != KCS_IDLE) && (kcs->state != KCS_HOSED)) {
+               printk(KERN_WARNING, "KCS is now in the state %d\n", 
kcs->state);
                return IPMI_NOT_IN_MY_STATE_ERR;
+       }
 
        if (kcs_debug & KCS_DEBUG_MSG) {
                printk(KERN_DEBUG "start_kcs_transaction -");
diff --git a/drivers/char/ipmi/ipmi_smic_sm.c b/drivers/char/ipmi/ipmi_smic_sm.c
index b6225bba2..690d4f53e 100644
--- a/drivers/char/ipmi/ipmi_smic_sm.c
+++ b/drivers/char/ipmi/ipmi_smic_sm.c
@@ -126,8 +126,10 @@ static int start_smic_transaction(struct si_sm_data *smic,
        if (size > MAX_SMIC_WRITE_SIZE)
                return IPMI_REQ_LEN_EXCEEDED_ERR;
 
-       if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED))
+       if ((smic->state != SMIC_IDLE) && (smic->state != SMIC_HOSED)) {
+               printk(KERN_WARNING, "SMIC is now in the state %d\n", 
smic->state);
                return IPMI_NOT_IN_MY_STATE_ERR;
+       }
 
        if (smic_debug & SMIC_DEBUG_MSG) {
                printk(KERN_DEBUG "start_smic_transaction -");
-- 
2.17.1



_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer