On Friday, April 2, 2021, Corey Minyard <miny...@acm.org> wrote:
> On Tue, Mar 30, 2021 at 09:16:42PM +0300, Andy Shevchenko wrote:
> > By one of the previous clean up change we got a temporary variable to
> hold
> > a device pointer. It can be utilized in other calls in the ->probe() and
> > save a bit of LOCs.
>
> The description here isn't accurate, there is no previous change where a
> temporary variable comes in. This change adds the temporary variable.
>
>
Oops, it has leftovers from similar change done by me somewhere else.
> This change is ok, but doesn't add much value.
>
>
One line less and better readability.
> -corey
>
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> > ---
> > drivers/char/ipmi/ipmi_si_platform.c | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/char/ipmi/ipmi_si_platform.c
> b/drivers/char/ipmi/ipmi_si_platform.c
> > index 009563073d30..954c297b459b 100644
> > --- a/drivers/char/ipmi/ipmi_si_platform.c
> > +++ b/drivers/char/ipmi/ipmi_si_platform.c
> > @@ -309,6 +309,7 @@ static int find_slave_address(struct si_sm_io *io,
> int slave_addr)
> >
> > static int acpi_ipmi_probe(struct platform_device *pdev)
> > {
> > + struct device *dev = &pdev->dev;
> > struct si_sm_io io;
> > acpi_handle handle;
> > acpi_status status;
> > @@ -318,21 +319,20 @@ static int acpi_ipmi_probe(struct platform_device
> *pdev)
> > if (!si_tryacpi)
> > return -ENODEV;
> >
> > - handle = ACPI_HANDLE(&pdev->dev);
> > + handle = ACPI_HANDLE(dev);
> > if (!handle)
> > return -ENODEV;
> >
> > memset(&io, 0, sizeof(io));
> > io.addr_source = SI_ACPI;
> > - dev_info(&pdev->dev, "probing via ACPI\n");
> > + dev_info(dev, "probing via ACPI\n");
> >
> > io.addr_info.acpi_info.acpi_handle = handle;
> >
> > /* _IFT tells us the interface type: KCS, BT, etc */
> > status = acpi_evaluate_integer(handle, "_IFT", NULL, &tmp);
> > if (ACPI_FAILURE(status)) {
> > - dev_err(&pdev->dev,
> > - "Could not find ACPI IPMI interface type\n");
> > + dev_err(dev, "Could not find ACPI IPMI interface type\n");
> > return -EINVAL;
> > }
> >
> > @@ -349,10 +349,11 @@ static int acpi_ipmi_probe(struct platform_device
> *pdev)
> > case 4: /* SSIF, just ignore */
> > return -ENODEV;
> > default:
> > - dev_info(&pdev->dev, "unknown IPMI type %lld\n", tmp);
> > + dev_info(dev, "unknown IPMI type %lld\n", tmp);
> > return -EINVAL;
> > }
> >
> > + io.dev = dev;
> > io.regsize = DEFAULT_REGSIZE;
> > io.regshift = 0;
> >
> > @@ -376,9 +377,7 @@ static int acpi_ipmi_probe(struct platform_device
> *pdev)
> >
> > io.slave_addr = find_slave_address(&io, io.slave_addr);
> >
> > - io.dev = &pdev->dev;
> > -
> > - dev_info(io.dev, "%pR regsize %d spacing %d irq %d\n",
> > + dev_info(dev, "%pR regsize %d spacing %d irq %d\n",
> > res, io.regsize, io.regspacing, io.irq);
> >
> > request_module("acpi_ipmi");
> > --
> > 2.30.2
> >
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
