On 07. 08. 21, 11:19, Uwe Kleine-König wrote:
The caller of this function (parisc_driver_remove() in
arch/parisc/kernel/drivers.c) ignores the return value, so better don't
return any value at all to not wake wrong expectations in driver authors.
The only function that could return a non-zero value before was
ipmi_parisc_remove() which returns the return value of
ipmi_si_remove_by_dev(). Make this function return void, too, as for all
other callers the value is ignored, too.
Also fold in a small checkpatch fix for:
WARNING: Unnecessary space before function pointer arguments
+ void (*remove) (struct parisc_device *dev);
Acked-by: Dmitry Torokhov <dmitry.torok...@gmail.com> (for drivers/input)
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
changes since v1 sent with Message-Id:
20210806093938.1950990-1-u.kleine-koe...@pengutronix.de:
- Fix a compiler error noticed by the kernel test robot
- Add Ack for Dmitry
arch/parisc/include/asm/parisc-device.h | 4 ++--
drivers/char/ipmi/ipmi_si.h | 2 +-
drivers/char/ipmi/ipmi_si_intf.c | 6 +-----
drivers/char/ipmi/ipmi_si_parisc.c | 4 ++--
drivers/char/ipmi/ipmi_si_platform.c | 4 +++-
drivers/input/keyboard/hilkbd.c | 4 +---
drivers/input/serio/gscps2.c | 3 +--
drivers/net/ethernet/i825xx/lasi_82596.c | 3 +--
drivers/parport/parport_gsc.c | 3 +--
drivers/scsi/lasi700.c | 4 +---
drivers/scsi/zalon.c | 4 +---
drivers/tty/serial/mux.c | 3 +--
For the TTY piece:
Acked-by: Jiri Slaby <jirisl...@kernel.org>
thanks,
--
--
js
suse labs
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
