On Fri, Aug 13, 2021 at 07:12:57PM +0800, Wen Yang wrote: > fix the following compilation warnings: > > >> drivers/char/ipmi/ipmi_si_intf.c:689:5: error: expected ')' > msg[2]); > ^ > drivers/char/ipmi/ipmi_si_intf.c:686:4: note: to match this '(' > dev_warn_ratelimited(smi_info->io.dev,
Thanks, I already fixed this. -corey > > Reported-by: kernel test robot <l...@intel.com> > Signed-off-by: Wen Yang <weny...@linux.alibaba.com> > Cc: Corey Minyard <miny...@acm.org> > Cc: openipmi-developer@lists.sourceforge.net > --- > drivers/char/ipmi/ipmi_si_intf.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c > b/drivers/char/ipmi/ipmi_si_intf.c > index 5bf9271..6ccaa01 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -592,7 +592,7 @@ static void handle_transaction_done(struct smi_info > *smi_info) > if (msg[2] != 0) { > /* Error clearing flags */ > dev_warn_ratelimited(smi_info->io.dev, > - "Error clearing flags: %2.2x\n", msg[2]); > + "Error clearing flags: %2.2x\n", > msg[2]); > } > smi_info->si_state = SI_NORMAL; > break; > @@ -684,9 +684,8 @@ static void handle_transaction_done(struct smi_info > *smi_info) > smi_info->handlers->get_result(smi_info->si_sm, msg, 4); > if (msg[2] != 0) { > dev_warn_ratelimited(smi_info->io.dev, > - "Couldn't get irq info: %x,\n" > - "Maybe ok, but ipmi might run very slowly.\n", > - msg[2]); > + "Couldn't get irq info: %x. Maybe > ok, but ipmi might run very slowly.\n", > + msg[2]); > smi_info->si_state = SI_NORMAL; > break; > } > @@ -722,8 +721,8 @@ static void handle_transaction_done(struct smi_info > *smi_info) > smi_info->handlers->get_result(smi_info->si_sm, msg, 4); > if (msg[2] != 0) > dev_warn_ratelimited(smi_info->io.dev, > - "Could not set the global enables: 0x%x.\n", > - msg[2]); > + "Could not set the global enables: > 0x%x.\n", > + msg[2]); > > if (smi_info->supports_event_msg_buff) { > smi_info->curr_msg = ipmi_alloc_smi_msg(); > @@ -1344,8 +1343,8 @@ static int try_get_dev_id(struct smi_info *smi_info) > if (cc != IPMI_CC_NO_ERROR && > ++retry_count <= GET_DEVICE_ID_MAX_RETRY) { > dev_warn_ratelimited(smi_info->io.dev, > - "BMC returned 0x%2.2x, retry get bmc device id\n", > - cc); > + "BMC returned 0x%2.2x, retry get > bmc device id\n", > + cc); > goto retry; > } > } > -- > 1.8.3.1 > _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer