On Fri, Aug 27, 2021 at 01:27:17AM +0200, Pavel Cahyna wrote:
> On Thu, Aug 26, 2021 at 05:05:27PM -0500, Corey Minyard wrote:
> > On Thu, Aug 26, 2021 at 10:26:34PM +0200, Pavel Cahyna wrote:
> > > Hello Corey,
> > >
> > > On Wed, Aug 25, 2021 at 08:31:13PM -0500, Corey Minyard wrote:
> > > > On Wed, Aug 25, 2021 at 08:24:05PM +0200, Pavel Cahyna wrote:
> > > > > at a quick glance at header file diffs, it seems to me that the
> > > > > Windows
> > > > > DLL changes are introducing library API changes even for non-Windows
> > > > > builds. Specifically, commit:
> > > > >
> > > > > 26e0921e77b6db359e7b018e8d439fcd1222d891 seems to affect the API of
> > > > > libIPMIlanserv.so.0.0.1
> > > > > cb416caa52dd73e53ada88ccda4aa496154519e8 seems to affect the API of
> > > > > libOpenIPMIcmdlang.so.0.0.5
> > > > >
> > > > > Is that correct? If so, it seems that those libraries should have
> > > > > their
> > > > > major version numbers bumped.
> > > >
> > > > Yeah, I suppose. lanserv is not that critical for library
> > > > compatibility, and I seriously doubt anyone is using cmdlang. So I
> > > > didn't work about it.
> > > >
> > > > If you like I can update these and do a new release.
> > >
> > > Thank you for the quick reply. Updating the major version is certainly a
> > > valid approach, but I would actually prefer to preserve compatibility.
> > > This way maintainers of distribution packages would not need to worry
> > > whether those libraries are important enough or not to introduce a
> > > compatibility package (which would be the correct approach, but quite an
> > > inconvenience). Actually, preserving compatibility does not seem that
> > > difficult. It seems to be enough to declare those symbols as weak
> > > (conditionally - not on Windows) and call them only if the new function
> > > pointers are NULL. Attached is a patch which does just that (for
> > > lanserv). Let me know what you think and I can do similar approach for
> > > cmdlang.
> >
> > This will work fine, I think. A few things I would like to change...
> >
> > Can you not modify dllvisibility.h and add all the include file stuff to
> > a separate include file? It doesn't have anything to do with dll
> > visibility, so it really doesn't belong there. And it make it easier to
> > yank out later. Plus you can comment why the code is there.
> >
> > Can you deprecate the weak symbols? That way people will know they
> > shouldn't use them any more.
>
> I don't think this is feasible, as the only code that uses the symbols
> is actually the library itself, so the deprecation warning will be
> printed only when compiling the library, not when compiling the user
> code. Or do you have some tip on how to do that?
There were prototypes for all these functions, you would need to re-add
the prototypes and then deprecate them.
> The posix_vlog symbol
> also does not seem to have been visibly deprecatred before being
> removed.
Yeah, that wasn't a good idea. It's better if people are alerted.
-corey
>
> P.
>
> >
> > And can you send this in a more git-friendly manner, with a
> > Signed-off-by line and such? Either a merge request or via
> > git-send-email or something like that. That way you get into the logs
> > and get credit.
> >
> > Thanks,
> >
> > -corey
> >
> > >
> > > I tested the result using ipmi_sim: ipmi_sim from 2.0.29 dumps core when
> > > used together with the lanserv library from 2.0.31, but works after
> > > building the library with my patch. Unmodified ipmi_sim binary from
> > > 2.0.31 also works with the patched library.
> > >
> > > Best regards, Pavel
> >
> > > diff --git a/lanserv/OpenIPMI/lanserv.h b/lanserv/OpenIPMI/lanserv.h
> > > index 57ed757e..8f3d8bad 100644
> > > --- a/lanserv/OpenIPMI/lanserv.h
> > > +++ b/lanserv/OpenIPMI/lanserv.h
> > > @@ -236,6 +236,8 @@ typedef struct ipmi_tick_handler_s {
> > > struct ipmi_tick_handler_s *next;
> > > } ipmi_tick_handler_t;
> > >
> > > +IPMI_LANSERV_WEAK(void, ipmi_register_tick_handler, (ipmi_tick_handler_t
> > > *handler));
> > > +
> > > typedef struct oem_handlers_s
> > > {
> > > void *oem_data;
> > > diff --git a/lanserv/OpenIPMI/lanserv_dllvisibility.h
> > > b/lanserv/OpenIPMI/lanserv_dllvisibility.h
> > > index 73f55e63..8dfb0d9d 100644
> > > --- a/lanserv/OpenIPMI/lanserv_dllvisibility.h
> > > +++ b/lanserv/OpenIPMI/lanserv_dllvisibility.h
> > > @@ -56,6 +56,8 @@
> > > #ifndef __LANSERV_DLLVISIBILITY_H
> > > #define __LANSERV_DLLVISIBILITY_H
> > >
> > > +#include <stddef.h>
> > > +
> > > #if defined _WIN32 || defined __CYGWIN__
> > > #ifdef BUILDING_IPMI_LANSERV_DLL
> > > #ifdef __GNUC__
> > > @@ -63,12 +65,15 @@
> > > #else
> > > #define IPMI_LANSERV_DLL_PUBLIC __declspec(dllexport) // Note:
> > > actually gcc seems to also supports this syntax.
> > > #endif
> > > + // Calling back to user code not supported, set the weak symbol to
> > > NULL always.
> > > + #define IPMI_LANSERV_WEAK(ret, sym, decl) static ret (*sym)decl =
> > > NULL
> > > #else
> > > #ifdef __GNUC__
> > > #define IPMI_LANSERV_DLL_PUBLIC __attribute__ ((dllimport))
> > > #else
> > > #define IPMI_LANSERV_DLL_PUBLIC __declspec(dllimport) // Note:
> > > actually gcc seems to also supports this syntax.
> > > #endif
> > > +#define IPMI_LANSERV_WEAK(ret, sym, decl) // Nothing
> > > #endif
> > > #define IPMI_LANSERV_DLL_LOCAL
> > > #else
> > > @@ -79,6 +84,16 @@
> > > #define IPMI_LANSERV_DLL_PUBLIC
> > > #define IPMI_LANSERV_DLL_LOCAL
> > > #endif
> > > + #ifdef BUILDING_IPMI_LANSERV_DLL
> > > + #ifdef __GNUC__
> > > + #define IPMI_LANSERV_WEAK(ret, sym, decl) __attribute__ ((weak))
> > > ret sym decl
> > > + #else
> > > + // Weak symbol not supported as we can not generate #pragma nor
> > > _Pragma from cpp
> > > + #define IPMI_LANSERV_WEAK(ret, sym, decl) static ret (*sym)decl =
> > > NULL
> > > + #endif
> > > + #else
> > > + #define IPMI_LANSERV_WEAK(ret, sym, decl) ret sym decl
> > > + #endif
> > > #endif
> > >
> > > #endif /* __LANSERV_DLLVISIBILITY_H */
> > > diff --git a/lanserv/OpenIPMI/mcserv.h b/lanserv/OpenIPMI/mcserv.h
> > > index c2a04648..de8d1440 100644
> > > --- a/lanserv/OpenIPMI/mcserv.h
> > > +++ b/lanserv/OpenIPMI/mcserv.h
> > > @@ -84,6 +84,19 @@ void ipmi_mc_set_chassis_control_func(lmc_data_t *mc,
> > > void *cb_data),
> > > void *cb_data);
> > >
> > > +IPMI_LANSERV_WEAK(int, ipmi_mc_alloc_unconfigured, (sys_data_t *sys,
> > > unsigned char ipmb,
> > > + lmc_data_t **rmc));
> > > +
> > > +IPMI_LANSERV_WEAK(unsigned char, ipmi_mc_get_ipmb, (lmc_data_t *mc));
> > > +IPMI_LANSERV_WEAK(channel_t **, ipmi_mc_get_channelset, (lmc_data_t
> > > *mc));
> > > +IPMI_LANSERV_WEAK(ipmi_sol_t *, ipmi_mc_get_sol, (lmc_data_t *mc));
> > > +IPMI_LANSERV_WEAK(startcmd_t *, ipmi_mc_get_startcmdinfo, (lmc_data_t
> > > *mc));
> > > +IPMI_LANSERV_WEAK(user_t *, ipmi_mc_get_users, (lmc_data_t *mc));
> > > +IPMI_LANSERV_WEAK(pef_data_t *, ipmi_mc_get_pef, (lmc_data_t *mc));
> > > +
> > > +IPMI_LANSERV_WEAK(void, ipmi_resend_atn, (channel_t *chan));
> > > +IPMI_LANSERV_WEAK(msg_t *, ipmi_mc_get_next_recv_q, (channel_t *chan));
> > > +
> > > /*
> > > * FRUs have a semaphore that can be use to grant exclusive access.
> > > * The semaphore is attempted to get before read and write operations,
> > > @@ -165,6 +178,8 @@ int check_msg_length(msg_t *msg,
> > > unsigned int len,
> > > unsigned char *rdata,
> > > unsigned int *rdata_len);
> > > +IPMI_LANSERV_WEAK(void, ipmi_set_chassis_control_prog,
> > > + (lmc_data_t *mc, const char *prog));
> > >
> > > void ipmi_mc_set_dev_revision(lmc_data_t *mc, unsigned char
> > > dev_revision);
> > > void ipmi_mc_set_fw_revision(lmc_data_t *mc, unsigned char
> > > fw_revision_major,
> > > @@ -172,6 +187,10 @@ void ipmi_mc_set_fw_revision(lmc_data_t *mc,
> > > unsigned char fw_revision_major,
> > > void ipmi_mc_set_aux_fw_revision(lmc_data_t *mc,
> > > unsigned char aux_fw_revision[4]);
> > > const char *get_lanserv_version(void);
> > > +IPMI_LANSERV_WEAK(int, sol_read_config,
> > > + (char **tokptr, sys_data_t *sys, const char **err));
> > > +
> > > +IPMI_LANSERV_WEAK(int, ipmi_mc_users_changed, (lmc_data_t *mc));
> > >
> > > /*
> > > * Types and functions for registering handlers with the MC emulator.
> > > diff --git a/lanserv/callback.h b/lanserv/callback.h
> > > new file mode 100644
> > > index 00000000..eb9f18fa
> > > --- /dev/null
> > > +++ b/lanserv/callback.h
> > > @@ -0,0 +1,68 @@
> > > +/*
> > > + * callback.h
> > > + *
> > > + * MontaVista IPMI LAN server include file
> > > + *
> > > + * Author: MontaVista Software, Inc.
> > > + * Corey Minyard <miny...@mvista.com>
> > > + * sou...@mvista.com
> > > + *
> > > + * Copyright 2003,2004,2005 MontaVista Software Inc.
> > > + *
> > > + * This software is available to you under a choice of one of two
> > > + * licenses. You may choose to be licensed under the terms of the GNU
> > > + * Lesser General Public License (GPL) Version 2 or the modified BSD
> > > + * license below. The following disclamer applies to both licenses:
> > > + *
> > > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
> > > + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
> > > + * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> > > + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> > > + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> > > + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
> > > +` * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> > > AND
> > > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> > > + * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> > > THE
> > > + * USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > > DAMAGE.
> > > + *
> > > + * GNU Lesser General Public Licence
> > > + *
> > > + * This program is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU Lesser General Public License
> > > + * as published by the Free Software Foundation; either version 2 of
> > > + * the License, or (at your option) any later version.
> > > + *
> > > + * You should have received a copy of the GNU Lesser General Public
> > > + * License along with this program; if not, write to the Free
> > > + * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> > > + *
> > > + * Modified BSD Licence
> > > + *
> > > + * Redistribution and use in source and binary forms, with or without
> > > + * modification, are permitted provided that the following conditions
> > > + * are met:
> > > + *
> > > + * 1. Redistributions of source code must retain the above copyright
> > > + * notice, this list of conditions and the following disclaimer.
> > > + * 2. Redistributions in binary form must reproduce the above
> > > + * copyright notice, this list of conditions and the following
> > > + * disclaimer in the documentation and/or other materials provided
> > > + * with the distribution.
> > > + * 3. The name of the author may not be used to endorse or promote
> > > + * products derived from this software without specific prior
> > > + * written permission.
> > > + */
> > > +
> > > +#ifndef __CALLBACK_H
> > > +#define __CALLBACK_H
> > > +
> > > +/*
> > > + * Macros to get callbacks that exist either as function pointers in
> > > some structure
> > > + * or as functions in user code.
> > > + * Pointers take precedence, functions exist for backward compatibility.
> > > + */
> > > +
> > > +#define LANSERV_CB(obj, field, name) ( (obj)->field ? (obj)->field :
> > > (name) )
> > > +#define LANSERV_CB_IPMI(obj, name) LANSERV_CB(obj, name, ipmi_ ## name)
> > > +
> > > +#endif /* __CALLBACK_H */
> > > diff --git a/lanserv/config.c b/lanserv/config.c
> > > index 453750eb..d59e93fe 100644
> > > --- a/lanserv/config.c
> > > +++ b/lanserv/config.c
> > > @@ -65,6 +65,9 @@
> > > #include <OpenIPMI/serserv.h>
> > > #include <OpenIPMI/ipmbserv.h>
> > > #include <OpenIPMI/persist.h>
> > > +#include <OpenIPMI/mcserv.h>
> > > +
> > > +#include "callback.h"
> > >
> > > void
> > > read_persist_users(sys_data_t *sys)
> > > @@ -80,11 +83,11 @@ read_persist_users(sys_data_t *sys)
> > > if (!mc)
> > > continue;
> > >
> > > - p = read_persist("users.mc%2.2x", sys->mc_get_ipmb(mc));
> > > + p = read_persist("users.mc%2.2x", LANSERV_CB_IPMI(sys,
> > > mc_get_ipmb)(mc));
> > > if (!p)
> > > continue;
> > >
> > > - users = sys->mc_get_users(mc);
> > > + users = LANSERV_CB_IPMI(sys, mc_get_users)(mc);
> > > for (j = 0; j <= MAX_USERS; j++) {
> > > void *data;
> > > unsigned int len;
> > > @@ -124,14 +127,14 @@ write_persist_users(sys_data_t *sys)
> > > user_t *users;
> > > persist_t *p;
> > >
> > > - if (!mc || !sys->mc_users_changed(mc))
> > > + if (!mc || !LANSERV_CB_IPMI(sys, mc_users_changed)(mc))
> > > continue;
> > >
> > > - p = alloc_persist("users.mc%2.2x", sys->mc_get_ipmb(mc));
> > > + p = alloc_persist("users.mc%2.2x", LANSERV_CB_IPMI(sys,
> > > mc_get_ipmb)(mc));
> > > if (!p)
> > > return ENOMEM;
> > >
> > > - users = sys->mc_get_users(mc);
> > > + users = LANSERV_CB_IPMI(sys, mc_get_users)(mc);
> > > for (j = 0; j <= MAX_USERS; j++) {
> > > add_persist_int(p, users[j].valid, "%d.valid", j);
> > > add_persist_int(p, users[j].link_auth, "%d.link_auth", j);
> > > @@ -834,12 +837,13 @@ read_config(sys_data_t *sys,
> > > } else if (strcmp(tok, "serial") == 0) {
> > > err = serserv_read_config(&tokptr, sys, &errstr);
> > > } else if (strcmp(tok, "sol") == 0) {
> > > - err = sys->sol_read_config(&tokptr, sys, &errstr);
> > > + err = LANSERV_CB(sys, sol_read_config, sol_read_config)
> > > + (&tokptr, sys, &errstr);
> > > } else if (strcmp(tok, "chassis_control") == 0) {
> > > char *prog;
> > > err = get_delim_str(&tokptr, &prog, &errstr);
> > > if (!err)
> > > - sys->set_chassis_control_prog(sys->mc, prog);
> > > + LANSERV_CB_IPMI(sys, set_chassis_control_prog)(sys->mc, prog);
> > > } else if (strcmp(tok, "name") == 0) {
> > > err = get_delim_str(&tokptr, &sys->name, &errstr);
> > > } else if (strcmp(tok, "startcmd") == 0) {
> > > @@ -860,7 +864,7 @@ read_config(sys_data_t *sys,
> > > err = get_uchar(&tokptr, &ipmb, &errstr);
> > > if (!err) {
> > > lmc_data_t *mc;
> > > - err = sys->mc_alloc_unconfigured(sys, ipmb, &mc);
> > > + err = LANSERV_CB_IPMI(sys, mc_alloc_unconfigured)(sys, ipmb,
> > > &mc);
> > > if (err == ENOMEM) {
> > > errstr = "Out of memory";
> > > err = -1;
> > > @@ -869,11 +873,11 @@ read_config(sys_data_t *sys,
> > > err = -1;
> > > } else {
> > > sys->mc = mc;
> > > - sys->cusers = sys->mc_get_users(mc);
> > > - sys->chan_set = sys->mc_get_channelset(mc);
> > > - sys->cpef = sys->mc_get_pef(mc);
> > > - sys->startcmd = sys->mc_get_startcmdinfo(mc);
> > > - sys->sol = sys->mc_get_sol(mc);
> > > + sys->cusers = LANSERV_CB_IPMI(sys, mc_get_users)(mc);
> > > + sys->chan_set = LANSERV_CB_IPMI(sys, mc_get_channelset)(mc);
> > > + sys->cpef = LANSERV_CB_IPMI(sys, mc_get_pef)(mc);
> > > + sys->startcmd = LANSERV_CB_IPMI(sys,
> > > mc_get_startcmdinfo)(mc);
> > > + sys->sol = LANSERV_CB_IPMI(sys, mc_get_sol)(mc);
> > > }
> > > }
> > > } else if (strcmp(tok, "console") == 0) {
> > > diff --git a/lanserv/lanserv_ipmi.c b/lanserv/lanserv_ipmi.c
> > > index ccd60015..c3c2cdbe 100644
> > > --- a/lanserv/lanserv_ipmi.c
> > > +++ b/lanserv/lanserv_ipmi.c
> > > @@ -73,6 +73,9 @@
> > >
> > > #include <OpenIPMI/persist.h>
> > > #include <OpenIPMI/extcmd.h>
> > > +#include <OpenIPMI/mcserv.h>
> > > +
> > > +#include "callback.h"
> > >
> > > static int
> > > is_authval_null(uint8_t *val)
> > > @@ -512,7 +515,7 @@ lan_return_rsp(channel_t *chan, msg_t *msg, rsp_msg_t
> > > *rsp)
> > >
> > > return_rsp(lan, msg, NULL, rsp);
> > >
> > > - msg = lan->sysinfo->mc_get_next_recv_q(chan);
> > > + msg = LANSERV_CB_IPMI(lan->sysinfo, mc_get_next_recv_q)(chan);
> > > if (!msg)
> > > return;
> > > while (msg) {
> > > @@ -531,7 +534,7 @@ lan_return_rsp(channel_t *chan, msg_t *msg, rsp_msg_t
> > > *rsp)
> > >
> > > chan->free(chan, msg);
> > >
> > > - msg = lan->sysinfo->mc_get_next_recv_q(chan);
> > > + msg = LANSERV_CB_IPMI(lan->sysinfo, mc_get_next_recv_q)(chan);
> > > }
> > > if (chan->recv_in_q)
> > > chan->recv_in_q(chan, 0);
> > > @@ -729,7 +732,7 @@ handle_get_channel_cipher_suites(lanserv_data_t *lan,
> > > msg_t *msg)
> > > if (chan == 0xe)
> > > chan = lan->channel.channel_num;
> > >
> > > - channels = lan->sysinfo->mc_get_channelset(lan->channel.mc);
> > > + channels = LANSERV_CB_IPMI(lan->sysinfo,
> > > mc_get_channelset)(lan->channel.mc);
> > > channel = channels[chan];
> > > if (!channel) {
> > > return_err(lan, msg, NULL, IPMI_NOT_PRESENT_CC);
> > > @@ -3202,7 +3205,7 @@ ipmi_lan_init(lanserv_data_t *lan)
> > >
> > > lan->tick_handler.handler = ipmi_lan_tick;
> > > lan->tick_handler.info = lan;
> > > - lan->sysinfo->register_tick_handler(&lan->tick_handler);
> > > + LANSERV_CB_IPMI(lan->sysinfo,
> > > register_tick_handler)(&lan->tick_handler);
> > >
> > > out:
> > > return rv;
> > > diff --git a/lanserv/marvell-bmc/marvell_mod.c
> > > b/lanserv/marvell-bmc/marvell_mod.c
> > > index b5b15e05..41a07b5c 100644
> > > --- a/lanserv/marvell-bmc/marvell_mod.c
> > > +++ b/lanserv/marvell-bmc/marvell_mod.c
> > > @@ -72,6 +72,7 @@
> > > #include <OpenIPMI/lanserv.h>
> > > #include <OpenIPMI/mcserv.h>
> > >
> > > +#include "callback.h"
> > > #include "wiw.h"
> > >
> > > #define PVERSION "2.0.12"
> > > @@ -3052,7 +3053,7 @@ ipmi_sim_module_init(sys_data_t *sys, const char
> > > *initstr_i)
> > > }
> > > }
> > >
> > > - rv = sys->mc_alloc_unconfigured(sys, 0x20, &bmc_mc);
> > > + rv = LANSERV_CB_IPMI(sys, mc_alloc_unconfigured)(sys, 0x20, &bmc_mc);
> > > if (rv) {
> > > sys->log(sys, OS_ERROR, NULL,
> > > "Unable to allocate an mc: %s", strerror(rv));
> > > @@ -3099,7 +3100,7 @@ ipmi_sim_module_init(sys_data_t *sys, const char
> > > *initstr_i)
> > > }
> > > }
> > >
> > > - rv = sys->mc_alloc_unconfigured(sys, board_ipmb[num], &mc);
> > > + rv = LANSERV_CB_IPMI(sys, mc_alloc_unconfigured)(sys, board_ipmb[num],
> > > &mc);
> > > if (rv) {
> > > sys->log(sys, OS_ERROR, NULL,
> > > "Unable to allocate an mc: %s", strerror(rv));
> > > @@ -3285,7 +3286,7 @@ ipmi_sim_module_post_init(sys_data_t *sys)
> > > */
> > > unsigned char data[13];
> > > memset(data, 0, sizeof(data));
> > > - data[4] = sys->mc_get_ipmb(bmc_mc);
> > > + data[4] = LANSERV_CB_IPMI(sys, mc_get_ipmb)(bmc_mc);
> > > data[5] = 0; /* LUN */
> > > data[6] = 0x04; /* Event message revision for IPMI 1.5. */
> > > data[7] = 0x1d; /* System boot initiated. */
> > > diff --git a/lanserv/serial_ipmi.c b/lanserv/serial_ipmi.c
> > > index 8ba8f7d0..b7255341 100644
> > > --- a/lanserv/serial_ipmi.c
> > > +++ b/lanserv/serial_ipmi.c
> > > @@ -63,6 +63,7 @@
> > > #include <OpenIPMI/ipmi_mc.h>
> > > #include <OpenIPMI/ipmi_msgbits.h>
> > > #include <OpenIPMI/serserv.h>
> > > +#include <OpenIPMI/mcserv.h>
> > >
> > > #define EVENT_BUFFER_GLOBAL_ENABLE (1 << 2)
> > > #define EVENT_LOG_GLOBAL_ENABLE (1 << 3)
> > > @@ -1008,6 +1009,8 @@ vm_connected(serserv_data_t *si)
> > > si->connected = 1;
> > > if (si->sysinfo->resend_atn)
> > > si->sysinfo->resend_atn(&si->channel);
> > > + else if (ipmi_resend_atn)
> > > + ipmi_resend_atn(&si->channel);
> > > }
> > >
> > > static void
> >
> >
> > > _______________________________________________
> > > Openipmi-developer mailing list
> > > Openipmi-developer@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/openipmi-developer
> >
>
>
>
> _______________________________________________
> Openipmi-developer mailing list
> Openipmi-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openipmi-developer
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
