From: "Steven Rostedt (Google)" <rost...@goodmis.org>

Before a timer is freed, del_timer_shutdown() must be called.

Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/

Cc: Corey Minyard <miny...@acm.org>
Cc: openipmi-developer@lists.sourceforge.net
Signed-off-by: Steven Rostedt (Google) <rost...@goodmis.org>
---
 drivers/char/ipmi/ipmi_msghandler.c | 2 +-
 drivers/char/ipmi/ipmi_ssif.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c 
b/drivers/char/ipmi/ipmi_msghandler.c
index 49a1707693c9..b577f66f3ca6 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -5540,7 +5540,7 @@ static void __exit cleanup_ipmi(void)
                 * here.
                 */
                atomic_set(&stop_operation, 1);
-               del_timer_sync(&ipmi_timer);
+               del_timer_shutdown(&ipmi_timer);
 
                initialized = false;
 
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index e1072809fe31..bb4df879a5ab 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1273,8 +1273,8 @@ static void shutdown_ssif(void *send_info)
                schedule_timeout(1);
 
        ssif_info->stopping = true;
-       del_timer_sync(&ssif_info->watch_timer);
-       del_timer_sync(&ssif_info->retry_timer);
+       del_timer_shutdown(&ssif_info->watch_timer);
+       del_timer_shutdown(&ssif_info->retry_timer);
        if (ssif_info->thread) {
                complete(&ssif_info->wake_thread);
                kthread_stop(ssif_info->thread);
-- 
2.35.1


_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to