On 2/27/23 01:31, Hans de Goede wrote:
> Hi Randy,
>
> On 2/26/23 06:39, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> REGMAP is selected 94 times and is depended on 11 times in
>> current linux-next. Eliminate the uses of "depends on" by
>> converting them to "select".
>
> Thank you for your work on this. Mixing of depends on vs select
> is a real problem with many Kconfig symbols.
>
>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of
>> depending on it
>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending
>> on it
>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on
>> it
>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending
>> on it
>
> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
> (platform-drivers-x86) tree, or do you plan to merge this whole series
> in one go through some other tree?
Hi Hans,
Please merge them thru the pdx86 tree.
Thanks.
> If you plan to merge the whole series through some other tree,
> here is my acked by for doing so for 5/8 and 6/8:
>
> Acked-by: Hans de Goede <hdego...@redhat.com>
>
> Regards,
>
> Hans
>
>
>
>
>>
>> diffstat:
>> drivers/char/ipmi/Kconfig | 3 ++-
>> drivers/clk/Kconfig | 2 +-
>> drivers/gpio/Kconfig | 2 +-
>> drivers/leds/Kconfig | 2 +-
>> drivers/platform/mellanox/Kconfig | 9 ++++-----
>> drivers/platform/x86/Kconfig | 3 ++-
>> drivers/thermal/intel/Kconfig | 3 ++-
>> drivers/tty/serial/8250/Kconfig | 3 ++-
>> 8 files changed, 15 insertions(+), 12 deletions(-)
>>
>> Cc: Andrew Jeffery <and...@aj.id.au>
>> Cc: Corey Minyard <miny...@acm.org>
>> Cc: openipmi-developer@lists.sourceforge.net
>> Cc: Arnd Bergmann <a...@arndb.de>
>> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>> Cc: Riku Voipio <riku.voi...@linaro.org>
>> Cc: Stephen Boyd <sb...@kernel.org>
>> Cc: Michael Turquette <mturque...@baylibre.com>
>> Cc: linux-...@vger.kernel.org
>> Cc: Michael Walle <mich...@walle.cc>
>> Cc: Linus Walleij <linus.wall...@linaro.org>
>> Cc: Bartosz Golaszewski <b...@bgdev.pl>
>> Cc: linux-g...@vger.kernel.org
>> Cc: Dan Murphy <dmur...@ti.com>
>> Cc: Pavel Machek <pa...@ucw.cz>
>> Cc: Jacek Anaszewski <jacek.anaszew...@gmail.com>
>> Cc: Lee Jones <l...@kernel.org>
>> Cc: linux-l...@vger.kernel.org
>> Cc: Darren Hart <dvh...@infradead.org>
>> Cc: Hans de Goede <hdego...@redhat.com>
>> Cc: Michael Shych <michae...@nvidia.com>
>> Cc: Mark Gross <markgr...@kernel.org>
>> Cc: Vadim Pasternak <vad...@nvidia.com>
>> Cc: platform-driver-...@vger.kernel.org
>> Cc: Yegnesh S Iyer <yegnesh.s.i...@intel.com>
>> Cc: Bin Gao <bin....@intel.com>
>> Cc: Zhang Rui <rui.zh...@intel.com>
>> Cc: "Rafael J. Wysocki" <raf...@kernel.org>
>> Cc: Daniel Lezcano <daniel.lezc...@linaro.org>
>> Cc: Amit Kucheria <am...@kernel.org>
>> Cc: linux...@vger.kernel.org
>> Cc: Oskar Senft <o...@google.com>
>> Cc: linux-ser...@vger.kernel.org
>>
>
--
~Randy
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
