> Perfect, I'll queue it for the next kernel release.  I can get it into
> the current release if it's urgent.

Thanks, that's great.  Not urgent, we can apply the patch manually anyway.

> The change that caused this was c608966f3f9c "ipmi: fix msg stack when
> IPMI is disconnected" and it came in between 6.1 and 6.6.  I'm adding
> the author of that patch because this change may affect that.
>
> In hindsight I think the fix that caused this is wrong.  I'm not sure
> how what the author said was happening could happen.  There's a limit
> of 100 messages per user.  I am inclined right now to revert that
> change.

So just checking with you what is most likely.  Are you going to add the
patch from https://sourceforge.net/p/openipmi/mailman/message/59220700/ and
not revert the patch for c608966f3f9c, or are you also going to revert that
patch?  A quick look myself over c608966f3f9c it wasn't immediately obvious
to me how it caused this problem and I would expect that the patch you
provided last week would be needed anyway?  The crucial part of your fix
seemed to me to be where you return from smi_event_handler after receiving
SI_SM_HOSED instead of 'goto restart'.  Although I admit I haven't looked
very hard at the message handler code.

Best regards
Mark
_______________________________________________
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

Reply via email to