On Wed, Jan 14, 2026 at 10:10:34AM +0800, Matt Johnston wrote: > Hi Corey, > > On Tue, 2026-01-13 at 10:00 -0600, Corey Minyard wrote: > > On Tue, Jan 13, 2026 at 05:41:34PM +0800, Matt Johnston wrote: > > > IPMB doesn't use i2c reads, but the handler needs to set a value. > > > Otherwise an i2c read will return an uninitialised value from the bus > > > driver. > > > > This is fine, I suppose. It's probably better to do this. > > > > Are you actually using this code? How was it found? > > I'm not using IPMB, so haven't tested the patch on hardware. > We received a patch for mctp-i2c read handling, that made me notice > the uninitialised value problem there. I had a look over other > i2c_slave_register() kernel users to see if the problem was common > (mctp-i2c used ipmi-ipmb as a bit of a reference during development too).
Ok, thanks for the history on this. It's in my tree. -corey > > https://lore.kernel.org/netdev/20260108101829.1140448-1- > [email protected]/ > https://lore.kernel.org/netdev/20260113-mctp-read-fix-v1-1- > [email protected]/ > > Cheers, > Matt > _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
