On Tue, 28 Jan 2025 16:12:14 GMT, Kevin Rushforth <[email protected]> wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line
>> 286:
>>
>>> 284: LOG("-> need to active application");
>>> 285: dispatch_async(dispatch_get_main_queue(), ^{
>>> 286: [NSApp activateIgnoringOtherApps:YES];
>>
>> should we add a comment about possible removal of this API in newer
>> platforms?
>> (I would suggest also include the JBS reference so the context can be
>> obtained by the person who will be fixing this code in the future).
>
> I don't want to do either of these in this PR. My comment in the PR
> Description about possible API removal is independent of this bug and
> something I just happened to notice -- plus it's speculative on my part. I
> will file a follow-on place-holder bug for this, but there isn't anything
> actionable at this point. Also, I don't like the practice of putting bug IDs
> in for fixed bugs except in unusual cases (this isn't one of them).
I filed [JDK-8348878](https://bugs.openjdk.org/browse/JDK-8348878) to track our
use of the deprecated `[NSApp activateIgnoringOtherApps]` method.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1685#discussion_r1932485436
