On Sun, 13 Sep 2026 12:19:21 GMT, Marius Hanl <[email protected]> wrote:

>> This is an idea to move out the `:apps` build from the `build.gradle`.
>> And to add an `INCLUDE_APPS` flag, that is `true` by default to control 
>> whether we actually want to build the `:apps` when running `gradle all` or 
>> if we actually need to clean them when running `gradle clean`.
>> 
>> I see two advantages:
>> - IMO, the main `build.gradle` should focus on JavaFX and not so much on 
>> anything else, like apps
>> - As of now, when I did run `gradle clean`, I always need to install `Ant`, 
>> just because the apps are also cleaned which I did not even build before.
>> This is problematic, because:
>>   - I think most of the people do not have `Ant`, it is very rarely used 
>> nowadays
>>   - It is also not preinstalled in pretty much every OS / distribution I 
>> tried. And I usually only installed for `OpenJFX` and never need it for 
>> anything else. If possible, it would be good if this is not needed if you 
>> just want to run tests and build JavaFX
>>     - For reference, when running CachyOS I could just build JavaFX out of 
>> the box without ever installing anything.  This is a very nice experience 
>> and should help people to contribute. The only thing I did run into was, 
>> well, `Ant` when running `gradle clean`
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Marius Hanl has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains five additional 
> commits since the last revision:
> 
>  - improve doc
>  - revert apps.gradle split
>  - Merge branch 'master' of https://github.com/openjdk/jfx into 
> 8090896-Allow-skipping-apps-build
>  - change default to true
>  - 8090896: Allow skipping apps build

Marked as reviewed by nlisker (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/2291#pullrequestreview-5190670083

Reply via email to