On Fri, 18 Sep 2026 19:39:58 GMT, Andy Goryachev <[email protected]> wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into fontwork
>> - Glyph shaping and LCD rendering changes require system properties
>> - Added Swing version of the cascade
>> - Added manual text rendering test
>> - Upped contrast and adjusted it for white-on-black text
>> - Merge remote-tracking branch 'upstream/master' into fontwork
>> - Slight tweak to natural/symmetric choice
>> - LCD text rendering is sharper and on Windows less likely to create
>> distorted glyphs
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
> line 135:
>
>> 133: lcdEnabled = lcdProp.equals("true");
>> 134: String lcdRenderProp = System.getProperty("prism.lcdrendering",
>> "default");
>> 135: newLCDRendering = lcdEnabled && lcdRenderProp.equals("new");
>
> I wonder if a different, more descriptive value would be better than "new".
> What if in the future there is something newer than "new"?
I knew we would have a conversation about naming and that it would change. Not
sure what name to use. The best I can think of is "contrast" because it tends
to increase the contrast at least for symmetric text. Suggestions are welcome.
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
> line 138:
>
>> 136:
>> 137: String glyphShapingProp =
>> System.getProperty("prism.glyphshaping", "default");
>> 138: symmetricGlyphs = glyphShapingProp.equals("symmetric");
>
> can we get these new properties documented somewhere?
>
> specifically, I'd like to see
> 1. full property name
> 2. possible values, default value when the property is not specified
> 3. brief explanation of the property effect on rendering, assuming the user
> has no prior background
> 4. applicable platforms (explaining differences between the platforms, if any)
>
> a set of screenshots illustrating different options might also be good.
> Maybe we could create /doc-files/graphics/ and put an .md file there?
I was going to ask about that. I want to document this but didn't know if there
was a standard place for this. I believe the existing prism settings are on a
wiki somewhere (?). Anyway, I'll look into this.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2284#discussion_r4051510070
PR Review Comment: https://git.openjdk.org/jfx/pull/2284#discussion_r4051516250
