It seems like the test is not written to handle multiple Locales, so if you could file a bug, we'll fix it (I note that it could probably be in a "BeforeClass" block as one-time setup rather than setting it before each test).

As for your other test failures, I presume you are using FX 9-dev? Are you running in "legacy" mode (building and testing with jdk-9+109 with no JIGSAW_HOME being set)? If so, I haven't seen that error before. We continuously run tests in this mode with no failures. Did you remove (and not just rename) jfxrt.jar from your jdk-9 boot JDK?

-- Kevin


Alexander Nyssen wrote:
Hi,

I could resolve this by changing the setup method of 
LocalDateTimeStringConverterTest to the following:

@Before public void setup() {
    // tests require that default locale is English
    Locale.setDefault(Locale.ENGLISH);
}
Maybe that should be added to make it robust.

Unfortunately, I am now stuck, because the succeeding controls tests fail, as 
it seems all with the following NoClassDefFoundError:

test.javafx.scene.control.TreeViewTest > test_rt_31200_tableRow FAILED
    java.lang.NoClassDefFoundError: javafx.scene.control.Control
        at test.javafx.scene.control.TreeViewTest.setup(TreeViewTest.java:121)

7133 tests completed, 6326 failed, 239 skipped
:controls:test FAILED

FAILURE: Build failed with an exception.

The build succeeded (using gradle). Any idea what might be wrong?
Regards,
Alexander

Am 17.06.2016 um 07:56 schrieb Alexander Nyssen <alexan...@nyssen.org>:

Hi,

in order to be able to contribute to OpenJFX, I am currently trying to set up my 
development environment. After checking out the latest head from hg clone 
http://hg.openjdk.java.net/openjfx/9-dev/rt 
<http://hg.openjdk.java.net/openjfx/9-dev/rt>, compilation succeeds, but tests 
fail with the following:

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[0] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[0] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[1] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[1] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_parser[2] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_parser(LocalDateTimeStringConverterTest.java:144)

test.javafx.util.converter.LocalDateTimeStringConverterTest > 
converter_with_specified_formatter_and_null_parser[2] FAILED
    org.junit.ComparisonFailure: expected:<12 Januar[y] 1985, 12:34:56> but 
was:<12 Januar[] 1985, 12:34:56>
        at org.junit.Assert.assertEquals(Assert.java:123)
        at org.junit.Assert.assertEquals(Assert.java:145)
        at 
test.javafx.util.converter.LocalDateTimeStringConverterTest.converter_with_specified_formatter_and_null_parser(LocalDateTimeStringConverterTest.java:152)

It seems they are not robust against having a default locale different to en_US 
(Januar is the correct German translation for January; my default locale seems 
to be de_DE).

Regards,
Alexander


Reply via email to