Hello Kevin, Phil, I have incorporated review comments, Please take a look.
http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/ <http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/> Thanks, Arun > On 04-Oct-2016, at 12:15 AM, Arunprasad Rajkumar > <arunprasad.rajku...@oracle.com> wrote: > > Hello Kevin, Phil, Guru > > Please review the following fix. > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8088205 > > Webrev: http://cr.openjdk.java.net/~arajkumar/8088205/webrev.00 > > Analysis: Some Web Fonts(like Thin.ttf, refer the attachment) doesn’t have > valid entry in the TTF Naming Table. Due to missing entry, > “CTFontCreateWithName” is not returning correct font reference. > > Solution: Use “CGFontCreateWithDataProvider”, it takes font path as a > parameter and creates a CGFontRef, then create a CTFontRef using CGFontRef. > “CGFontCreateWithDataProvider” doesn’t support TTC font type, so use > “CTFontCreateWithName” as a fallback if CGFontRef creation fails. > > Test - 1: Load http://www.cnet.com with HelloWebView > > Test - 2: Try simple fx application present in > https://bugs.openjdk.java.net/secure/attachment/62649/CustomFontApp.tar.bz2 > > Regards, > Arun > > > <Thin.ttf>
