Mandy Chung wrote:
Looks good.
Thank you for your help on this and for your review.
"Deploying an Application as a Module” section is duplicated in several
JavaBean*Property classes. One alternative is to move it to the package
summary. I have no objection to leave it as is.
I think I'll keep it as is for the JavaBean*Property classes. Especially
since we don't have anything currently in the package summary. There
might be other detailed information that could go there, too.
-- Kevin
Mandy
On May 3, 2017, at 4:30 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8177566
Here is the updated webrev with (I hope) all comments addressed:
http://cr.openjdk.java.net/~kcr/8177566/webrev.01/complete-webrev/
For those who reviewed the earlier webrev, I have prepared delta webrevs.
* Delta webrev for the fix itself (just a slight change to the error message,
plus I hid the unused public methods in MethodUtil) :
http://cr.openjdk.java.net/~kcr/8177566/webrev.01/delta-fix-only.00/
* No changes in the tests
* Delta webrev for the doc changes:
http://cr.openjdk.java.net/~kcr/8177566/webrev.01/delta-doc-only.00/
* The sparse javadocs are also updated here:
http://cr.openjdk.java.net/~kcr/8177566/webrev.01/javadoc/
-- Kevin
Kevin Rushforth wrote:
This review is being cross-posted to both openjfx-dev and jigsaw-dev.
Please review the proposed fix for:
https://bugs.openjdk.java.net/browse/JDK-8177566
http://cr.openjdk.java.net/~kcr/8177566/webrev.00/complete-webrev/
Details of the fix as well as notes to reviewers are in the bug report [1]
(e.g., I've also generated separate webrevs for the fix itself, the doc
changes, and the test changes).
-- Kevin
[1] https://bugs.openjdk.java.net/browse/JDK-8177566?focusedCommentId=14074243&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14074243
