I checked this as well, and even without checking you can see why this fixes the tests (on Windows, with the PseudoPrinter). This is a very important commit, as it fixes the automated build on Windows, which makes it much easier to make progress without regression.
- Johan On Wed, Mar 21, 2018 at 6:32 PM Kevin Rushforth <kevin.rushfo...@oracle.com> wrote: > I'll defer to Phil on this review. > > I have no concerns over the fix, and can confirm that the failing tests > now pass on my system. > > -- Kevin > > > Laurent Bourgès wrote: > > Kevin, > > > > Please review this webrev that fixes the NPE in getMediaName(): > > JBS: https://bugs.openjdk.java.net/browse/JDK-8196617 > > webrev: http://cr.openjdk.java.net/~lbourges/fx/fx-8196617.0/ > > <http://cr.openjdk.java.net/%7Elbourges/fx/fx-8196617.0/> > > > > It was tested OK on the appveyor CI that failed before the patch. > > > > Thanks, > > Laurent >
