Hi Kevin,

This sounds reasonable to me.

best regards,

-- daniel

On 23/03/2018 17:51, Kevin Rushforth wrote:
Hi Daniel,

Thanks for the review.

I like the idea of removing the unused levels and methods.

As for directly using System.Logger.Level, we have enough usages of the Level and convenience logging methods (e.g., "warn", "fine", etc.), that I think it's better to file a follow-up issue (to minimize the changes and so it would be more feasible to review the existing changes). The idea of doing a refactor / rename of the convenience methods and level names to match seems like a good one for that follow-up JBS issue.

-- Kevin

Reply via email to