Thanks.

As a note to reviewers, if you want to test the new functionality, and be able to run JavaFX swing interop applications without adding qualified exports, you will need to use a recent OpenJDK 11 ea build as the boot JDK. If you use OpenJDK 10, it will work no better (and hopefully no worse) than before, meaning that you will still need the additional qualified exports.

-- Kevin

On 7/5/2018 11:29 PM, Prasanta Sadhukhan wrote:

My Bad. Please find modified webrev restoring the filter

http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.4/

Regards
Prasanta
On 7/6/2018 6:47 AM, Kevin Rushforth wrote:
One quick comment:

This no longer compiles with OpenJDK10. It looks like the logic to optionally filter out jdk.unsupported.desktop from javafx.swing's module-info.java got lost between the .2 and .3 versions.

-- Kevin


On 7/4/2018 4:35 AM, Prasanta Sadhukhan wrote:
Hi All,

Please review an enhancement to support openjfx swing interoperability once the dependancy of internal jdk classes are removed. JDK-8202199 <https://bugs.openjdk.java.net/browse/JDK-8202199> provided a new "jdk.unsupported.desktop" module in JDK 11 that exports public API that is intended to be used by the javafx.swing module and unbundled OpenJFX is now made to depend on these APIs to support interoperation between Swing and JavaFX components to replace previous use of internal APIs when it was part of Oracle JDK.

Bug: https://bugs.openjdk.java.net/browse/JDK-8195811
webrev: http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.3/

Regards
Prasanta



Reply via email to