On 9/28/2019 6:12 AM, Eric Bresie wrote:
I was wondering, does any of this information need to be added into any of the existing documentation?
Some of it already made it into the updated CONTRIBUTING.md [1] docs, but I'm sure it can be improved. Most of what I sent is transitional information aimed at existing contributors who have outstanding pull requests or who have an OpenJDK ID (i.e., Author, Committer, or Reviewer). That shouldn't go into the docs, since it will be outdated soon.
Maybe the following could be added to the CONTRIBUTING docs?
... As a best practice, please create a separate branch for each contribution. Name the branch with something that is meaningful to you. You can, but need not, include the JBS bug ID in the branch name. I strongly recommend that you not use your master branch for this purpose or it will become confusing. If you use your master branch at all, I recommend that you periodically sync in the upstream master branch (meaning that your master branch never has commits that aren't already in the upstream master).
If there are other things that could be done to make it more clear, we could also do that.
-- Kevin [1] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
