Yeah, this would be helpful. I'm pretty sure we've had requests for checking other dependencies (like missing packages, etc). Failing fast with an explicit error message is almost always better than wasting time tracking down strange build failures.

-- Kevin


On 10/17/2019 7:23 AM, Johan Vos wrote:
I heard similar reports from developers trying to build with gcc 4.x.
We might benefit from an assert early in the build.

On Thu, Oct 17, 2019 at 3:16 PM Kevin Rushforth <kevin.rushfo...@oracle.com <mailto:kevin.rushfo...@oracle.com>> wrote:

    The current toolchain for building JavaFX is gcc 8.2. As long as you
    don't build WebKit, it will still build with gcc 5.4.

    I just tried it on an Oracle Linux 7 machine with gcc 4.9.1 (which is
    what we used to use a couple years ago), and the build fails for
    me with
    the same error. Looks like you will need a newer gcc.

    -- Kevin


    On 10/16/2019 8:47 PM, Michael Franz wrote:
    > Hi,
    >
    > I did a clean install of CentOS 7, updated, added the necessary
    tools and
    > then cloned the repo and ran the default build.  I get the
    following errors:
    >
    
/home/test00/Source/jfx/modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp:598:1:
    > error: unused parameter ‘event’ [-Werror=unused-parameter]
    >   glass_gdk_master_pointer_grab(GdkEvent *event, GdkWindow *window,
    > GdkCursor *cursor) {
    >   ^
    >
    
/home/test00/Source/jfx/modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp:628:1:
    > error: unused parameter ‘event’ [-Werror=unused-parameter]
    >   glass_gdk_master_pointer_ungrab(GdkEvent *event) {
    >   ^
    > cc1plus: all warnings being treated as errors
    >
    >> Task :graphics:ccLinuxGlassGlassgtk2 FAILED
    > Is this expected?  I have not found any documentation specifing
    the minimum
    > version of gcc/g++ and wonder if I need to upgrade? I am using
    g++ (GCC)
    > 4.8.5 20150623 (Red Hat 4.8.5-39).  Also, other native code in
    the build
    > are treating the unused-parameter as a warning.  Why is this module
    > different?
    >
    
/home/test00/Source/jfx/modules/javafx.graphics/src/main/native-font/pango.c:429:26:
    > warning: unused parameter ‘that’ [-Wunused-parameter]
    >       (JNIEnv *env, jclass that, jlong arg0)
    >
    >
    > Here are the detailed steps I followed:
    > 0. sudo yum update
    > 1. sudo yum install git bison flex pkgconfig gtk2-devel gtk3-devel
    > pango-devel freetype-devel libXtst-devel java-11-openjdk-devel
    ant gcc-c++
    > libstdc++-static
    > 2. sudo alternatives --config java
    >    - specify Java 11
    > 3. git clone https://github.com/openjdk/jfx.git
    > 4. cd jfx
    > 5. bash ./gradelw
    >
    > Any suggestions is appreciated.
    >
    > Michael


Reply via email to