On Tue, 5 Nov 2019 06:28:33 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> On Wed, 30 Oct 2019 20:46:53 GMT, Kevin Rushforth <k...@openjdk.org> wrote: > >> The pull request has been updated with additional changes. >> >> ---------------- >> >> Added commits: >> - 5686a382: Update third-party license file to remove unneeded lines >> >> Changes: >> - all: https://git.openjdk.java.net/jfx/pull/26/files >> - new: https://git.openjdk.java.net/jfx/pull/26/files/7a520adc..5686a382 >> >> Webrevs: >> - full: https://webrevs.openjdk.java.net/jfx/26/webrev.01 >> - incr: https://webrevs.openjdk.java.net/jfx/26/webrev.00-01 >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 >> Stats: 13 lines in 1 file changed: 0 ins; 13 del; 0 mod >> Patch: https://git.openjdk.java.net/jfx/pull/26.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 > > modules/javafx.graphics/src/main/legal/mesa3d.md line 80: > >> 79: ---- >> 80: include/GL/glext.h >> 81: include/GL/glxext.h > > The copyright header of glx.h is not included here. Will it be good idea to > include it ? > > looks good to me, posted a small query in mesa3d.md file. The main license at the top of this file is the copyright header for `gl.h` and `glx.h`. In any case, this is as approved by our lawyers, so no changes should be made. PR: https://git.openjdk.java.net/jfx/pull/26