On Thu, 14 Nov 2019 14:35:28 GMT, Alexander Scherbatiy <[email protected]> wrote:
> On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth <[email protected]> wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy <[email protected]> >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>> >>> ---------------- >>> >>> Commits: >>> - f0f1866a: 8234174: Change IDEA VCS mapping to Git >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/37/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/37/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8234174 >>> Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/37.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/37/head:pull/37 >> >> @AlexanderScherbatiy this is the part that applies to you: >> >>> If you already are an OpenJDK >>> [Author](https://openjdk.java.net/bylaws#author), >>> [Committer](https://openjdk.java.net/bylaws#committer) or >>> [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click >>> [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) >>> to open a new issue so that we can record that fact. Please use "Add >>> GitHub user AlexanderScherbatiy" as summary for the issue. >> >> Also, please read the [contributing >> guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md). As >> with the JDK project, we need a JBS bug ID for every pull request. > > I have created issue JDK-8234174 Change IDEA VCS mapping to Git. > > I have created SKARA-161 to map my GitHub username to your OpenJDK username. Just one note: Idea can import the project from gradle, so many idea files on the project just gets on the way when committing. Not sure about this file in particular, but I think it would be better to remove IDE specific project files (for IDEs that supports it). PR: https://git.openjdk.java.net/jfx/pull/37
